[monitorlib, mock_uss] Add idempotent handler decorator #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barroco
approved these changes
Oct 13, 2023
| @@ -43,7 +43,7 @@ def __init__( | |||
| """ | |||
| self._lock = multiprocessing.RLock() | |||
| self._shared_memory = multiprocessing.shared_memory.SharedMemory( | |||
| create=True, size=capacity_bytes | |||
| create=True, size=capacity_bytes + 4 | |||
There was a problem hiding this comment.
Would you mind adding a comment on why the additional 4 bytes are required?
There was a problem hiding this comment.
Yeah, constants are better than magic numbers -- fixed, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to #28, duplicate requests to mock_uss instances are occasionally observed. Prior to this PR, such duplicate requests were identified and rejected, but this causes CI to fail when it could actually succeed. This PR introduces a decorator that can be applied to idempotent Flask view handlers to cache responses according to request ID and then return the cached response instead of invoking the underlying handler when a duplicate request is received. This decorator is then applied to idempotent, mutating mock_uss endpoints. The result is that if a mock_uss response is lost (this appears to occasionally be the case in CI), a client retry will receive a response identical to the lost response (as if the client received the initial successful response).